Added '/check -admin' #7

Closed
timovv wants to merge 2 commits from master into master
timovv commented 2013-05-21 06:01:03 +00:00 (Migrated from github.com)

Title says it all - added the '/check -admin' flag so that moderators are able to see admin requests if they wish.

Elevated requests are still viewable by default for admins.

Usage:

/check -admin p:#
/check -admin #### (doesn't do anything other than a normal /check would do)

Title says it all - added the '/check -admin' flag so that moderators are able to see admin requests if they wish. Elevated requests are still viewable by default for admins. Usage: /check -admin p:# /check -admin #### (doesn't do anything other than a normal /check would do)
Deaygo commented 2013-05-21 11:41:14 +00:00 (Migrated from github.com)

While this code looks good, I think that I would prefer this to be done in a different manner. If there is ever the need to extend the /check with more then just -admin then this method would not be sufficient.

While this code looks good, I think that I would prefer this to be done in a different manner. If there is ever the need to extend the /check with more then just -admin then this method would not be sufficient.
timovv commented 2013-05-22 01:17:04 +00:00 (Migrated from github.com)

I wasn't quite sure what you were looking for, however I've just made adding additional flags to /check (if we need them) simpler to do.

I wasn't quite sure what you were looking for, however I've just made adding additional flags to /check (if we need them) simpler to do.
Deaygo commented 2013-05-22 01:18:33 +00:00 (Migrated from github.com)

I've implemented something for this along with some other changes, I will be pushing this tomorrow.

I've implemented something for this along with some other changes, I will be pushing this tomorrow.
timovv commented 2013-05-22 04:51:16 +00:00 (Migrated from github.com)

Your implementation will probably be better than mine anyway, mine was a relatively quick and nasty fix.

Your implementation will probably be better than mine anyway, mine was a relatively quick and nasty fix.
Deaygo commented 2013-06-12 22:15:31 +00:00 (Migrated from github.com)

Just as an FYI for this thread, here is the commit for this.

Just as an FYI for this thread, [here](https://github.com/NerdNu/ModReq/commit/67d257174a3be71c31cce1f5855c5e1fc0b803bd) is the commit for this.

Pull request closed

Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
NerdNu/ModReq!7
No description provided.